cschantz/Linux-Server-Management-Toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Eliminate all bc command dependencies - replace with awk for portability

Browse Source 
PROBLEM:
- bc command not installed on all systems (requires bc package)
- 30 instances across toolkit causing potential failures
- bc is external dependency for floating-point arithmetic

SOLUTION:
- Replaced all bc usage with awk (universally available)
- Pattern: echo "X * Y" | bc → awk "BEGIN {printf \"%.2f\", X * Y}"
- Pattern: (( $(echo "X > Y" | bc -l) )) → awk comparison + bash test

FILES MODIFIED (8 files, 30 bc instances eliminated):
1. lib/threat-intelligence.sh (1 fix)
   - Line 310: Load average to integer conversion

2. lib/reference-db.sh (2 fixes)
   - Line 554: CPU load percentage calculation
   - Line 570: TCP retransmission comparison

3. lib/php-analyzer.sh (5 fixes)
   - Line 138: Script duration comparison
   - Lines 391-395: OPcache hit rate + wasted memory + cached scripts
   - Line 479: OPcache hit rate threshold

4. modules/performance/hardware-health-check.sh (1 fix)
   - Line 264: CPU frequency conversion (KHz to GHz)

5. modules/performance/network-bandwidth-analyzer.sh (3 fixes)
   - Line 168: Daily bandwidth threshold (50 GiB)
   - Line 238: Bytes to MB conversion
   - Lines 388-390: TCP retransmission percentage

6. modules/performance/php-optimizer.sh (2 fixes)
   - Lines 457, 653: OPcache hit rate comparisons

7. modules/diagnostics/system-health-check.sh (10 fixes)
   - Lines 345-350: Load per core + threshold calculations
   - Lines 354-358: Load trend detection (3 comparisons)
   - Lines 367-406: Load critical/warning/elevated checks
   - Lines 828-829: TCP retransmission analysis
   - Line 901: Clock offset detection
   - Line 1692: Network stats TCP retrans percent

8. tools/toolkit-qa-check.sh (QA improvements)
   - Added --exclude="toolkit-qa-check.sh" to prevent self-scanning
   - Eliminates false positives from QA script itself

TECHNICAL DETAILS:
- All awk commands use BEGIN block for pure calculation
- printf formatting preserves decimal precision (%.2f, %.1f, %.0f)
- Error handling with 2>/dev/null || echo fallbacks
- Ternary operators for comparisons: (condition ? 1 : 0)

TESTING:
✓ QA scan shows 0 CRITICAL, 0 HIGH, 0 MEDIUM, 0 LOW issues
✓ All 30 bc instances eliminated
✓ No external dependencies beyond standard bash + awk
✓ Toolkit now portable to minimal Linux installations

IMPACT:
+ Eliminates bc package dependency
+ 100% portable (awk included in all Unix/Linux systems)
+ Same accuracy for floating-point calculations
+ Faster execution (awk is typically faster than bc)
+ Better error handling with fallback values
This commit is contained in:
cschantz
2025-12-03 20:49:46 -05:00
parent 8cc1384a85
commit 154afff7fc
8 changed files with 69 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/diagnostics/system-health-check.sh
+30 -18
View File
@@ -342,25 +342,32 @@ analyze_cpu() {
local load_15min=$(uptime | awk -F'load average:' '{print $2}' | awk -F',' '{print $3}' | xargs)
# Calculate load per core
local load_per_core=$(echo "$load_1min / $cpu_cores" | bc -l 2>/dev/null | awk '{printf "%.2f", $0}' || echo "0")
local load_per_core=$(awk "BEGIN {printf \"%.2f\", $load_1min / $cpu_cores}" 2>/dev/null || echo "0")
# Calculate healthy load thresholds
local healthy_load=$(echo "$cpu_cores * 0.7" | bc -l | awk '{printf "%.1f", $0}')
local warning_load=$(echo "$cpu_cores * 1.0" | bc -l | awk '{printf "%.1f", $0}')
local critical_load=$(echo "$cpu_cores * 2.0" | bc -l | awk '{printf "%.1f", $0}')
local healthy_load=$(awk "BEGIN {printf \"%.1f\", $cpu_cores * 0.7}")
local warning_load=$(awk "BEGIN {printf \"%.1f\", $cpu_cores * 1.0}")
local critical_load=$(awk "BEGIN {printf \"%.1f\", $cpu_cores * 2.0}")
# Detect load trend (increasing, stable, decreasing)
local load_trend="stable"
if (( $(echo "$load_1min > $load_5min * 1.2" | bc -l) )); then
local trend_rapid=$(awk "BEGIN {print ($load_1min > $load_5min * 1.2 ? 1 : 0)}" 2>/dev/null || echo 0)
local trend_up=$(awk "BEGIN {print ($load_1min > $load_5min ? 1 : 0)}" 2>/dev/null || echo 0)
local trend_down=$(awk "BEGIN {print ($load_1min < $load_5min * 0.8 ? 1 : 0)}" 2>/dev/null || echo 0)
if [ "$trend_rapid" -eq 1 ]; then
load_trend="increasing rapidly"
elif (( $(echo "$load_1min > $load_5min" | bc -l) )); then
elif [ "$trend_up" -eq 1 ]; then
load_trend="increasing"
elif (( $(echo "$load_1min < $load_5min * 0.8" | bc -l) )); then
elif [ "$trend_down" -eq 1 ]; then
load_trend="decreasing"
fi
# Check load average with intelligent thresholds
if (( $(echo "$load_1min > $critical_load" | bc -l) )); then
local load_critical=$(awk "BEGIN {print ($load_1min > $critical_load ? 1 : 0)}" 2>/dev/null || echo 0)
local load_warning=$(awk "BEGIN {print ($load_1min > $warning_load ? 1 : 0)}" 2>/dev/null || echo 0)
if [ "$load_critical" -eq 1 ]; then
local top_cpu=$(ps aux --sort=-%cpu | head -6 | tail -5 | awk '{printf " • %-15s %6s %s\n", $1, $3"%", $11}')
add_issue "CRITICAL" "CPU - Extreme load" \
"Load average: ${load_1min} / ${load_5min} / ${load_15min}
@@ -379,7 +386,7 @@ ${top_cpu}" \
2. Kill if necessary: kill -9 [PID]
3. Check if under attack: Main Menu → Security → Bot Analyzer" \
92
elif (( $(echo "$load_1min > $warning_load" | bc -l) )); then
elif [ "$load_warning" -eq 1 ]; then
local top_cpu=$(ps aux --sort=-%cpu | head -4 | tail -3 | awk '{printf " • %-15s %6s %s\n", $1, $3"%", $11}')
add_issue "HIGH" "CPU - High load" \
"Load average: ${load_1min} / ${load_5min} / ${load_15min}
@@ -396,13 +403,16 @@ ${top_cpu}" \
• Check: ps aux --sort=-%cpu | head -20
• Review high-CPU processes and optimize if possible" \
76
elif (( $(echo "$load_1min > $healthy_load" | bc -l) )); then
add_issue "MEDIUM" "CPU - Elevated load" \
"Load average: ${load_1min} / ${load_5min} / ${load_15min}
else
local load_elevated=$(awk "BEGIN {print ($load_1min > $healthy_load ? 1 : 0)}" 2>/dev/null || echo 0)
if [ "$load_elevated" -eq 1 ]; then
add_issue "MEDIUM" "CPU - Elevated load" \
"Load average: ${load_1min} / ${load_5min} / ${load_15min}
Healthy threshold: < ${healthy_load}
Trend: ${load_trend}" \
"Monitor trends. Load is elevated but not critical yet." \
62
"Monitor trends. Load is elevated but not critical yet." \
62
fi
fi
# Get top CPU consumers
@@ -818,8 +828,9 @@ New connections may be dropped" \
tcp_out=$(echo "$tcp_out" | tr -d '\n\r' | grep -o '[0-9]*' | head -1)
tcp_out=${tcp_out:-1}
if [ "$tcp_out" -gt 1000000 ] 2>/dev/null; then
local retrans_percent=$(echo "scale=2; $tcp_retrans * 100 / $tcp_out" | bc 2>/dev/null || echo "0")
if (( $(echo "$retrans_percent > 5" | bc -l 2>/dev/null) )); then
local retrans_percent=$(awk "BEGIN {printf \"%.2f\", $tcp_retrans * 100 / $tcp_out}" 2>/dev/null || echo "0")
local retrans_high=$(awk "BEGIN {print ($retrans_percent > 5 ? 1 : 0)}" 2>/dev/null || echo 0)
if [ "$retrans_high" -eq 1 ]; then
# Get current MTU
local current_mtu=$(ip link show $(ip route | grep default | awk '{print $5}' | head -1) 2>/dev/null | grep mtu | awk '{print $5}')
@@ -891,7 +902,8 @@ Time drift can cause SSL certificate errors and authentication issues" \
# Convert to absolute value for comparison
offset_seconds=${offset_seconds#-}
if (( $(echo "$offset_seconds > 1" | bc -l 2>/dev/null || echo "0") )); then
local offset_high=$(awk "BEGIN {print ($offset_seconds > 1 ? 1 : 0)}" 2>/dev/null || echo 0)
if [ "$offset_high" -eq 1 ]; then
add_issue "HIGH" "TIME - Clock offset detected" \
"Time offset: ${sync_status}
Significant time drift detected" \
@@ -1682,7 +1694,7 @@ save_health_baseline() {
tcp_out=${tcp_out:-1}
local tcp_retrans_percent="0"
if [ "$tcp_out" -gt 1000000 ] 2>/dev/null; then
tcp_retrans_percent=$(echo "scale=2; $tcp_retrans * 100 / $tcp_out" | bc 2>/dev/null || echo "0")
tcp_retrans_percent=$(awk "BEGIN {printf \"%.2f\", $tcp_retrans * 100 / $tcp_out}" 2>/dev/null || echo "0")
fi
local rx_errors=0