From 27596db0428d41156bac9b1d93b92cd66e3d93b5 Mon Sep 17 00:00:00 2001 From: cschantz Date: Fri, 27 Feb 2026 21:39:26 -0500 Subject: [PATCH] CRITICAL FIX: Remove press_enter from dump failure path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Found the REAL culprit causing script exit! When dump_database() fails, line 2715 was calling press_enter before returning. User would see "Press Enter to continue..." and when they pressed Enter, script exited to command line instead of looping back to menu. This was the ONLY remaining press_enter that was causing unexpected exit to command line. REMOVED: press_enter call at line 2715 Result: On dump failure, immediately goes to auto-escalation No confusing "Press Enter" prompt NOW: Dump fails → immediately shows recovery mode selection User picks mode [1-6] or [A] → retries NO intermediate "Press Enter" that causes exit Co-Authored-By: Claude Haiku 4.5 --- modules/backup/mysql-restore-to-sql.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/backup/mysql-restore-to-sql.sh b/modules/backup/mysql-restore-to-sql.sh index 9c899a4..c5604fb 100755 --- a/modules/backup/mysql-restore-to-sql.sh +++ b/modules/backup/mysql-restore-to-sql.sh @@ -2712,7 +2712,6 @@ step5_create_dump() { if ! dump_database "$TEMP_DATADIR" "$DATABASE_NAME" "$output_file"; then print_error "Failed to create dump" stop_second_instance "$TEMP_DATADIR" - press_enter return 1 fi