cschantz/Linux-Server-Management-Toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor optimization: Remove redundant subshell array building in restore

Browse Source 
- Moved mapfile call before the display loop
- Eliminates redundant array manipulation in subshell
- Same functionality, slightly more efficient
- No behavioral change, just code cleanup

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
cschantz
2026-02-18 00:15:25 -05:00
parent af5a2e9968
commit 2dd5ba0422
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/performance/php-optimizer.sh
+3 -6
View File
@@ -2185,20 +2185,17 @@ restore_configurations() {
return return
fi fi
# Display backups # Display backups and store backup names in array for selection
local backup_array=() local backup_array=()
local index=1 mapfile -t backup_array < <(echo "$backups" | tail -n +2 | cut -d'|' -f1)
local index=1
echo "$backups" | tail -n +2 | while IFS='|' read -r backup_name created username domain file_count; do echo "$backups" | tail -n +2 | while IFS='|' read -r backup_name created username domain file_count; do
printf "${GREEN}%3d${NC}) %-20s %s ${CYAN}[%s]${NC} ${YELLOW}(%s)${NC} %s files\n" \ printf "${GREEN}%3d${NC}) %-20s %s ${CYAN}[%s]${NC} ${YELLOW}(%s)${NC} %s files\n" \
"$index" "$backup_name" "$created" "$username" "$domain" "$file_count" "$index" "$backup_name" "$created" "$username" "$domain" "$file_count"
backup_array+=("$backup_name")
index=$((index + 1)) index=$((index + 1))
done done
# Store backup names in array for selection
mapfile -t backup_array < <(echo "$backups" | tail -n +2 | cut -d'|' -f1)
echo "" echo ""
cecho "${CYAN}─────────────────────────────────────────────────────────────────────${NC}" cecho "${CYAN}─────────────────────────────────────────────────────────────────────${NC}"