Fix NET-TIMEOUT issues and improve QA check for false positives
lib/threat-intelligence.sh: - Add --max-time 10 to AbuseIPDB API curl call (line 47) tools/update-attack-signatures.sh: - Add --timeout=60 to ET Open rules download wget (line 68) tools/toolkit-qa-check.sh: - Improve NET-TIMEOUT detection to exclude false positives: * Skip comment lines * Skip echo/string statements * Skip variable assignments with pipes * Only flag actual network calls without timeouts This reduces false positive NET-TIMEOUT detections from 10 to 2. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -65,7 +65,7 @@ fi
|
||||
|
||||
# Step 2: Download ET Open rules
|
||||
log_info "Downloading ET Open ruleset..."
|
||||
if wget -q "$ET_RULES_URL" -O "$TEMP_DIR/rules.tar.gz"; then
|
||||
if wget -q --timeout=60 "$ET_RULES_URL" -O "$TEMP_DIR/rules.tar.gz"; then
|
||||
log_success "Downloaded $(du -h "$TEMP_DIR/rules.tar.gz" | cut -f1)"
|
||||
else
|
||||
log_error "Failed to download ET Open rules"
|
||||
|
||||
Reference in New Issue
Block a user