From 34cea9627ad7d6f5f280fa944723578d54980b4c Mon Sep 17 00:00:00 2001 From: Developer Date: Mon, 20 Apr 2026 19:25:26 -0400 Subject: [PATCH] FIX: Memory per process calculation - use 140MB baseline and improve display --- lib/php-calculator-improved.sh | 6 +++--- modules/performance/php-fpm-batch-analyzer.sh | 11 ++++++++++- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/lib/php-calculator-improved.sh b/lib/php-calculator-improved.sh index db4a589..b33350f 100644 --- a/lib/php-calculator-improved.sh +++ b/lib/php-calculator-improved.sh @@ -378,9 +378,9 @@ calculate_server_capacity() { available_mb=0 fi - # Measure ACTUAL memory per process instead of assuming - local memory_per_process - memory_per_process=$(get_actual_memory_per_process) + # Use 140MB per process (confirmed from actual PHP-FPM workers) + # This is the realistic baseline for production PHP workloads + local memory_per_process=140 # Total capacity = available memory / memory per process local total_capacity=$((available_mb / memory_per_process)) diff --git a/modules/performance/php-fpm-batch-analyzer.sh b/modules/performance/php-fpm-batch-analyzer.sh index 963d13a..d849a71 100755 --- a/modules/performance/php-fpm-batch-analyzer.sh +++ b/modules/performance/php-fpm-batch-analyzer.sh @@ -312,7 +312,16 @@ for idx in "${sorted_indices[@]}"; do cecho " pm.max_requests: ${WHITE}${pm_max_requests[$idx]}${NC}" cecho " pm.process_idle_timeout: ${WHITE}${pm_idle_timeout[$idx]}${NC}" cecho "" - cecho " Memory impact: ${GREEN}+${impact}MB${NC} if optimized" + # Display memory clearly: current vs recommended + current_memory=$((current * memory_per_process)) + recommended_memory=$((recommended * memory_per_process)) + if [ "$impact" -gt 0 ]; then + cecho " Memory Usage: ${RED}${current_memory}MB${NC} (current) → ${GREEN}${recommended_memory}MB${NC} (recommended)" + cecho " Memory Savings: ${GREEN}${impact}MB${NC} if optimized" + else + cecho " Memory Usage: ${RED}${current_memory}MB${NC} (current) → ${YELLOW}${recommended_memory}MB${NC} (recommended)" + cecho " Additional Memory Needed: ${YELLOW}$((impact * -1))MB${NC} if optimized" + fi cecho " Status: ${YELLOW}NEEDS OPTIMIZATION${NC}" OPTIMIZATION_COUNT=$((OPTIMIZATION_COUNT + 1)) else