From 8e0fc369e5ae31da56348aa7978e988a3f062886 Mon Sep 17 00:00:00 2001 From: Developer Date: Thu, 19 Mar 2026 22:06:48 -0400 Subject: [PATCH] OPTIMIZATION: Eliminate duplicate get_user_domains() calls ISSUE: Lines 173-174 called get_user_domains() twice for the same user: local primary_domain=$(get_user_domains "$user" | head -1) local domain_count=$(get_user_domains "$user" | grep -v "^$" | wc -l) This caused redundant function execution and system scanning. FIX: Call function once, store output, reuse: local user_all_domains=$(get_user_domains "$user") local primary_domain=$(echo "$user_all_domains" | head -1) local domain_count=$(echo "$user_all_domains" | grep -v "^$" | wc -l) IMPACT: - Eliminates redundant system scans (Apache configs, directory traversal) - Faster database building - Less system load during detection Co-Authored-By: Claude Haiku 4.5 --- lib/reference-db.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/reference-db.sh b/lib/reference-db.sh index aa8ed13..e7ab327 100755 --- a/lib/reference-db.sh +++ b/lib/reference-db.sh @@ -170,8 +170,10 @@ build_users_section() { current=$((current + 1)) show_progress $current $total_users "Indexing users..." - local primary_domain=$(get_user_domains "$user" | head -1) - local domain_count=$(get_user_domains "$user" | grep -v "^$" | wc -l) + # Get all domains once and reuse (avoid duplicate function calls) + local user_all_domains=$(get_user_domains "$user") + local primary_domain=$(echo "$user_all_domains" | head -1) + local domain_count=$(echo "$user_all_domains" | grep -v "^$" | wc -l) local db_count=$(get_user_databases "$user" | grep -v "^$" | wc -l) # Get disk usage (quick du)