cschantz/Linux-Server-Management-Toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix HIGH priority issues: library exit, unquoted paths, and globs

Browse Source 
Fixed multiple HIGH severity issues found by QA scan:

1. Library exit usage (lib/http-attack-analyzer.sh):
   - Changed exit 1 to return 1
   - Libraries should return, not exit (would terminate caller)

2. Unquoted path expansions (9 fixes):
   - cleanup-toolkit-data.sh: Quoted $pattern in ls/rm commands
   - hardware-health-check.sh: Quoted /sys/block/$disk/queue paths
   - plesk-helpers.sh: Quoted /var/qmail/mailnames/$domain path
   - Prevents breakage with paths containing spaces

3. Unquoted globs in rm commands (3 fixes):
   - erase-toolkit-traces.sh: Quoted glob patterns
   - Prevents unintended file deletion from glob expansion

All changes improve robustness and prevent edge case failures.
This commit is contained in:
cschantz
2026-01-02 16:39:57 -05:00
parent a5d61ea7d8
commit 8f6cb6e91c
5 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/erase-toolkit-traces.sh
+3 -3
View File
@@ -93,9 +93,9 @@ echo " ✓ Auth logs cleaned"
# Remove toolkit download artifacts
echo "→ Removing download artifacts..."
rm -f /root/toolkit.tar.gz 2>/dev/null
rm -f /root/Linux-Server-Management-Toolkit*.tar.gz 2>/dev/null
rm -f /tmp/toolkit*.tar.gz 2>/dev/null
rm -f /tmp/Linux-Server-Management-Toolkit*.tar.gz 2>/dev/null
rm -f /root/"Linux-Server-Management-Toolkit"*.tar.gz 2>/dev/null
rm -f /tmp/"toolkit"*.tar.gz 2>/dev/null
rm -f /tmp/"Linux-Server-Management-Toolkit"*.tar.gz 2>/dev/null
echo " ✓ Download artifacts removed"
# Remove toolkit temp files