cschantz/Linux-Server-Management-Toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIX: Add error handling to database counting pipes

Browse Source 
ISSUE:
Lines 214, 216, 224, 226 had same grep -v | wc -l pattern that fails
when all databases are system databases (filtered out by grep -v).

With set -eo pipefail:
- If no user databases exist: grep -v filters everything
- grep returns exit code 1 (no matches)
- Script crashes

SCENARIO:
Server with only system databases (mysql, information_schema, etc.)
1. Line 214: Count user databases
2. grep -v filters all of them
3. Returns exit code 1
4. Script crashes

FIXES:

Line 214: Plesk database count
- BEFORE: grep -v ... | wc -l
- AFTER: grep -v ... | wc -l || echo 0

Line 216: Standard database count
- BEFORE: grep -v ... | wc -l
- AFTER: grep -v ... | wc -l || echo 0

Line 224: Plesk database list
- BEFORE: grep -v ...
- AFTER: grep -v ... || echo ""

Line 226: Standard database list
- BEFORE: grep -v ...
- AFTER: grep -v ... || echo ""

IMPACT:
- Reference database building handles servers with no user databases
- Launcher no longer crashes on minimal database setups
- Graceful fallback to empty/zero values

Testing:
- bash -n validates syntax
- Returns sensible defaults (0 for counts, empty for lists)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
Developer
2026-03-19 22:12:59 -04:00
parent 9e48a9ecf1
commit 986b54b620
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/reference-db.sh
+5 -4
View File
@@ -211,9 +211,10 @@ build_databases_section() {
# Query databases - set MYSQL_PWD only for this command # Query databases - set MYSQL_PWD only for this command
local total_dbs local total_dbs
if [ -n "$plesk_password" ]; then if [ -n "$plesk_password" ]; then
total_dbs=$(MYSQL_PWD="$plesk_password" mysql -u admin -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$" | wc -l) # Use || echo 0 to handle grep failure (when all databases are system databases)
total_dbs=$(MYSQL_PWD="$plesk_password" mysql -u admin -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$" | wc -l || echo 0)
else else
total_dbs=$(mysql -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$" | wc -l) total_dbs=$(mysql -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$" | wc -l || echo 0)
fi fi
local current=0 local current=0
@@ -221,9 +222,9 @@ build_databases_section() {
# Get database list - set MYSQL_PWD only for this command # Get database list - set MYSQL_PWD only for this command
local databases local databases
if [ -n "$plesk_password" ]; then if [ -n "$plesk_password" ]; then
databases=$(MYSQL_PWD="$plesk_password" mysql -u admin -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$") databases=$(MYSQL_PWD="$plesk_password" mysql -u admin -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$" || echo "")
else else
databases=$(mysql -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$") databases=$(mysql -Ns -e "SHOW DATABASES" 2>/dev/null | grep -v "^information_schema$\|^mysql$\|^performance_schema$\|^sys$" || echo "")
fi fi
while IFS= read -r db; do while IFS= read -r db; do