Fix 10 HIGH integer comparisons in backup/maintenance/security modules

FIXES:
enable-cphulk.sh:
- Line 234: $file_ip_count → ${file_ip_count:-0}
- Line 333: $FAILED → ${FAILED:-0}

cleanup-toolkit-data.sh:
- Line 209: $cleaned_size → ${cleaned_size:-0} (3 instances)
- Line 236: $missing → ${missing:-0}

acronis-update.sh:
- Line 229: $UPGRADE_EXIT_CODE → ${UPGRADE_EXIT_CODE:-0}

acronis-install.sh:
- Line 301: $INSTALL_EXIT_CODE → ${INSTALL_EXIT_CODE:-0}

acronis-logs.sh:
- Line 64: $log_count → ${log_count:-0}
- Line 215: $old_logs → ${old_logs:-0}

IMPACT:
- Prevents errors in backup/maintenance scripts
- Safe defaults for all exit code checks
- More robust error handling

PROGRESS:
- Fixed 57+ integer comparison issues total
- Only 3 HIGH issues remaining!
- Total issues: 23 (was 41 originally)
This commit is contained in:
cschantz
2025-12-03 20:14:37 -05:00
parent 4757ae591d
commit c1eee9de66
5 changed files with 10 additions and 10 deletions
+2 -2
View File
@@ -231,7 +231,7 @@ if [ "$CSF_AVAILABLE" = true ]; then
done < "$csf_file"
# Track count per file
if [ $file_ip_count -gt 0 ]; then
if [ "${file_ip_count:-0}" -gt 0 ]; then
IP_SOURCE_COUNT["$file_display_name"]=$file_ip_count
fi
done
@@ -330,7 +330,7 @@ if [ "$CSF_AVAILABLE" = true ] && [ ${#CSF_ALLOW_IPS[@]} -gt 0 ]; then
print_success "Import complete:"
echo " • Imported: $IMPORTED"
echo " • Skipped (already whitelisted): $SKIPPED"
if [ $FAILED -gt 0 ]; then
if [ "${FAILED:-0}" -gt 0 ]; then
print_warning "Failed: $FAILED"
fi
fi