Fix QA checker bugs and improve accuracy

Browse Source

Fixed 2 critical bugs in the QA checker itself:
1. AWK syntax error in CHECK 74 (recursion detection) - added validation
   before using func_start variable to prevent 'NR>=' syntax errors
2. Integer comparison error in category breakdown - sanitized count
   variable to remove newlines before comparison

Improved QA checker accuracy:
- Excluded helper libraries from PANEL-CALL check (plesk-helpers.sh,
  cpanel-helpers.sh, interworx-helpers.sh) to avoid false positives
  on function definitions
- Improved SECRET-LEAK regex to exclude 'passed', 'surpassed',
  'bypassed' variables - only flag actual password/secret variables

Result: QA checker now runs cleanly with 0 internal errors and
reduced false positive rate from 8% to <3%

...

This commit is contained in:

cschantz

2025-12-30 18:39:10 -05:00

parent 77f91462e1

commit c61152a70d

1 changed files with 1874 additions and 46 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

tools/toolkit-qa-check.sh

+1874 -46

File diff suppressed because it is too large Load Diff