cschantz/Linux-Server-Management-Toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix critical bugs found by QA tool: grep -F, integer comparisons, function exports

Browse Source 
CRITICAL FIXES (8 → 0):
- Fix all 8 grep -F with regex anchors bugs
  - lib/reference-db.sh:420
  - lib/user-manager.sh:195, 254, 258, 317, 583, 590
  - modules/website/500-error-tracker.sh:313
  - Changed grep -F to grep for proper regex support

HIGH PRIORITY FIXES:
- Add 36 function exports for subshell availability
  - lib/system-detect.sh: 10 functions
  - lib/common-functions.sh: 26 functions

- Fix 27 integer comparisons with ${var:-0} validation
  - lib/common-functions.sh: 7 fixes
  - lib/ip-reputation.sh: 3 fixes
  - lib/user-manager.sh: 4 fixes
  - launcher.sh: 7 fixes
  - modules/website/500-error-tracker.sh: 1 fix
  - modules/performance/hardware-health-check.sh: 2 fixes
  - modules/performance/mysql-query-analyzer.sh: 1 fix
  - modules/security/bot-analyzer.sh: 11 fixes

- Change exit to return in library file
  - lib/common-functions.sh:246 (require_root function)

DOCUMENTATION:
- Add [DEVELOPMENT_WORKFLOW] section to REFDB_FORMAT.txt
  - Document QA script as "third option" for validation
  - Add recommended workflow for using QA tool
  - Document all 16 checks (11 bug + 5 performance)

IMPACT:
- Before: 41 issues (8 CRITICAL + 13 HIGH + 9 MEDIUM + 11 LOW)
- After: 30 issues (0 CRITICAL + 10 HIGH + 9 MEDIUM + 11 LOW)
- 27% reduction, all CRITICAL bugs eliminated

QA Tool: bash /tmp/toolkit-qa-check.sh /root/server-toolkit
This commit is contained in:
cschantz
2025-12-03 19:41:59 -05:00
parent 341df8e91d
commit cd38a457a4
10 changed files with 477 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/performance/hardware-health-check.sh
+2 -2
View File
@@ -216,7 +216,7 @@ check_memory_health() {
add_finding "CRITICAL" "Memory Errors Detected" \
"Total Memory: $total_mem
Slots: $populated_slots / $total_slots
ECC Support: $([ $ecc_support -gt 0 ] && echo 'Yes' || echo 'No')
ECC Support: $([ "${ecc_support:-0}" -gt 0 ] && echo 'Yes' || echo 'No')
Memory errors in dmesg: $mem_errors
Hardware errors in logs: $hw_mem_errors
@@ -233,7 +233,7 @@ $recent_errors" \
add_finding "INFO" "Memory Health Status" \
"Total Memory: $total_mem
Slots: $populated_slots / $total_slots
ECC Support: $([ $ecc_support -gt 0 ] && echo 'Yes' || echo 'No')
ECC Support: $([ "${ecc_support:-0}" -gt 0 ] && echo 'Yes' || echo 'No')
Memory errors: None detected
Installed Modules: