cschantz/Linux-Server-Management-Toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIX: Critical syntax error in bot-analyzer.sh (apostrophes in AWK comments)

Browse Source 
Problem: Bash script had CRITICAL syntax error at line 554
- AWK script was wrapped in single quotes '...'
- Comments inside AWK code contained apostrophes (it's, doesn't, etc.)
- In bash, apostrophe inside single-quoted string terminates the quote early
- This caused: bash -n to fail with "syntax error near unexpected token 'ua_lower,'"

Fix: Changed all contractions in AWK comments to avoid apostrophes
- "it's" → "it is"
- This preserves readability while maintaining bash syntax validity

Result:
- CRITICAL error eliminated
- bash -n now passes cleanly
- QA scan: CRITICAL=0 (was 1), exit code 361 (was 362)

Files changed:
- modules/security/bot-analyzer.sh (3 apostrophes removed from comments)

Root cause: When adding browser detection improvements in previous commit
(8f27baa), I used contractions in comments without realizing they break
AWK single-quote strings in bash.
This commit is contained in:
cschantz
2026-01-28 23:26:46 -05:00
parent 8f27baaeaa
commit ef740adba4
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/security/bot-analyzer.sh
+7 -11
View File
@@ -543,35 +543,31 @@ classify_bots() {
}
}
} else if (match(ua_lower, /bot|crawler|spider|scraper|curl|wget|python-requests|python-urllib|java\/|scan|check|monitor/)) {
# FIXED: Check for bot keywords FIRST, then verify it's not a legitimate browser
# FIXED: Check for bot keywords FIRST, then verify it is not a legitimate browser
# This prevents bots from bypassing detection by including browser strings
# FIRST: Check if it's actually a legitimate browser with complete UA signature
# FIRST: Check if it is actually a legitimate browser with complete UA signature
# Real browsers have: Mozilla/5.0 + platform + rendering engine + browser version
is_real_browser = 0
# Chrome/Chromium-based: Must have Chrome/ AND (AppleWebKit OR Mobile)
if (match(ua_lower, /chrome\/[0-9]/) && (match(ua_lower, /applewebkit/) || match(ua_lower, /mobile/))) {
is_real_browser = 1
}
} else if (match(ua_lower, /firefox\/[0-9]/) && match(ua_lower, /gecko\//)) {
# Firefox: Must have Firefox/ AND Gecko/
else if (match(ua_lower, /firefox\/[0-9]/) && match(ua_lower, /gecko\//)) {
is_real_browser = 1
}
} else if (match(ua_lower, /safari\/[0-9]/) && match(ua_lower, /version\//) && match(ua_lower, /applewebkit/) && !match(ua_lower, /chrome/)) {
# Safari: Must have Safari/ AND Version/ AND AppleWebKit (not Chrome)
else if (match(ua_lower, /safari\/[0-9]/) && match(ua_lower, /version\//) && match(ua_lower, /applewebkit/) && !match(ua_lower, /chrome/)) {
is_real_browser = 1
}
} else if (match(ua_lower, /edg\/[0-9]|edge\/[0-9]/)) {
# Edge: Must have Edg/ or Edge/
else if (match(ua_lower, /edg\/[0-9]|edge\/[0-9]/)) {
is_real_browser = 1
}
} else if (match(ua_lower, /samsungbrowser\/[0-9]|ucbrowser\/[0-9]|opr\/[0-9]/)) {
# Mobile browsers: Samsung, UC, Opera Mobile
else if (match(ua_lower, /samsungbrowser\/[0-9]|ucbrowser\/[0-9]|opr\/[0-9]/)) {
is_real_browser = 1
}
# If it's a real browser, skip bot classification
# If it is a real browser, skip bot classification
if (is_real_browser == 1) {
next
}