Added proper null/empty checks and variable quoting in 3 files:
1. wordpress-cron-manager.sh (2 issues):
- Added validation for $site_path before use
- Quoted variable in cron command to prevent word splitting
- Lines 446-449: Check if path is empty or invalid before processing
2. malware-scanner.sh (1 issue):
- Added safety check for $SCAN_DIR before suggesting rm -rf command
- Prevents dangerous rm operations if variable is empty or root
- Line 1583-1585: Guard against accidental deletions
3. mysql-restore-to-sql.sh (2 issues):
- Quoted $datadir in echo statements showing manual commands
- Lines 426, 441, 444, 447: Proper quoting in examples
Impact: Prevents potential issues from empty/undefined variables
Added validation checks for potentially empty variables before use
to prevent errors and unsafe operations.
WordPress Cron Manager (5 fixes):
- Added site_path validation after dirname operations
- Prevents using empty paths in cd commands and file operations
- Pattern: Check [ -z "$site_path" ] before use
Bot Analyzer:
- Quoted TEMP_DIR in trap command for safety
Hardware Health Check:
- Quoted MESSAGES_CACHE in trap command for safety
Note: 5 issues flagged in toolkit-qa-check.sh were false positives
(echo statements demonstrating bad patterns, not actual code issues)
Added existence checks and error handling for all source commands
to prevent silent failures when dependencies are missing.
Library files (use 'return' for error):
- reference-db.sh: Added checks for 3 dependencies
- mysql-analyzer.sh: Added checks for 3 dependencies
- domain-discovery.sh: Added checks for 2 dependencies
- system-detect.sh: Added check for common-functions.sh
- plesk-helpers.sh: Added check for common-functions.sh
- user-manager.sh: Added checks for 2 dependencies
Executable scripts (use 'exit' for error):
- wordpress-cron-manager.sh: Added checks for 2 dependencies
- website-error-analyzer.sh: Added checks for 4 dependencies
Pattern: [ -f "file" ] && source "file" || { echo "ERROR" >&2; return/exit 1; }
This ensures scripts fail fast with clear error messages when
required dependencies are missing, rather than continuing with
undefined functions.
FIXES:
wordpress-cron-manager.sh:
- Line 288-289: /var/cpanel/userdata → ${SYS_CPANEL_USERDATA_DIR:-/var/cpanel/userdata}
- Line 301-302: /var/cpanel/userdata → $userdata_base (uses same variable)
IMPACT:
- WordPress cron manager now uses configurable paths
- Better compatibility with customized cPanel installations
- Consistent with other toolkit modules
QA STATUS:
- MEDIUM issues: Should be 0 now (was 9)
- Remaining: 11 LOW issues only
MAJOR REFACTORING - 830 lines:
WordPress cron → system cron conversion tool. Converts wp-cron.php to real
system cron jobs with intelligent load distribution. Most complex refactoring
in the entire multi-panel project due to extensive WordPress discovery logic.
KEY CHANGES:
1. WordPress Discovery (3 locations - lines 166-181, 469-484, 844-859):
- Multi-panel wp-config.php finding
- cPanel: /home/*/public_html/wp-config.php
- InterWorx: /home/*/*/html/wp-config.php
- Plesk: /var/www/vhosts/*/httpdocs/wp-config.php
- Standalone: /var/www/html/wp-config.php
2. User/Domain Extraction (lines 193-219):
- Added multi-panel path parsing in Scanner (option 1)
- cPanel: Extract user from /home/$user, lookup domain from userdata
- InterWorx: Extract both user and domain from path structure
- Plesk: Extract domain from path, lookup user via plesk bin
- Standalone: Defaults to www-data/localhost
3. Domain→User→Path Lookup (lines 251-313):
- Complete rewrite for "Disable wp-cron for specific domain" (option 2)
- cPanel: Dual-method userdata search (main_domain + servername)
- InterWorx: V host config → SuexecUserGroup → /home/$user/$domain/html
- Plesk: Direct path /var/www/vhosts/$domain/httpdocs
- Most complex section - handles all edge cases
4. Helper Function (lines 48-73):
- Created extract_user_from_path() for multi-panel user extraction
- Used in 5 locations throughout script
- Handles cPanel/InterWorx (field 3) vs Plesk (domain→user lookup)
- Graceful fallbacks for standalone (www-data)
5. Cron Job Management:
- All cron operations now use extracted user from helper function
- Works with user-specific crontabs on all panels
- Staggered timing still works across all panels
REPLACED PATTERNS:
- find /home/*/public_html → case statement (3 occurrences)
- /var/cpanel/userdata lookups → multi-panel domain→user (2 major sections)
- user=$(echo "$site_path" | cut -d'/' -f3) → extract_user_from_path() (5 occurrences)
IMPACT:
- WordPress cron management now works on cPanel, InterWorx, Plesk, standalone
- Properly discovers WordPress across all docroot patterns
- Correctly maps domains→users→paths on all panels
- Most complex multi-panel refactoring complete!
COMPLIANCE: Class C ✅
- ✅ Uses system-detect.sh (SYS_CONTROL_PANEL)
- ✅ Multi-panel case statements for all discovery
- ✅ Helper function for user extraction
- ✅ No hardcoded paths outside panel-specific cases
- ✅ Syntax verified with bash -n
REFACTORING COMPLETE: 38/38 modules = 100%! 🎉
The domain lookup was failing because it only searched for 'servername:' in /var/cpanel/userdata/*/main files, but cPanel stores domain information differently:
- main files use 'main_domain: domain.com' (YAML format)
- domain-specific files use 'servername: domain.com' (YAML format)
Changes:
• Added two-step domain lookup process
• Method 1: Check main_domain in /var/cpanel/userdata/*/main files
• Method 2: Fallback to search all domain files for servername
• Skip cache files (.cache, cache, cache.json) during search
• Applied fix to all three domain lookup locations (options 2, 5, 6)
This fixes the "WordPress installation not found for domain" error that occurred when domains weren't configured as main_domain.
Tested with pickledperil.com - lookup now works correctly.
Changes:
- Modified disable_wpcron_in_config() to place DISABLE_WP_CRON before "stop editing" comment
- This follows WordPress convention for custom constants
- Removes any existing DISABLE_WP_CRON lines first (clean placement)
- Falls back to after <?php if "stop editing" not found
Placement Logic:
1. Remove any existing DISABLE_WP_CRON (anywhere in file)
2. Add before "/* That's all, stop editing! */" comment (line ~93)
3. Fallback: Add after <?php if no "stop editing" found
Example Placement:
```
if ( ! defined( 'WP_DEBUG' ) ) {
define( 'WP_DEBUG', false );
}
define('DISABLE_WP_CRON', true); ← Added here
/* That's all, stop editing! Happy publishing. */
```
Benefits:
- Follows WordPress conventions
- Placed with other custom constants
- Clean, predictable location
- Easy to find for manual edits
https://claude.com/claude-code
Changes:
- Added "0) Cancel" option to all menu prompts
- Added "(or 0 to cancel)" to all text input prompts
- Ensures users can back out of any operation at any time
- Scripts affected:
- website-error-analyzer.sh (scope selection, time range)
- 500-error-tracker.sh (time range selection)
- wordpress-cron-manager.sh (all domain/user input prompts, status checks)
User Experience Improvements:
- No more being trapped in prompts
- Clear cancel instructions on every input
- Consistent "Operation cancelled" messaging
- Proper exit codes (0 for user cancellation)
Tested:
✓ website-error-analyzer.sh - cancel on scope selection
✓ 500-error-tracker.sh - cancel on time selection
✓ wordpress-cron-manager.sh - cancel on domain/user input
✓ All cancellations return cleanly to menu
https://claude.com/claude-code
Changes:
- Created modules/website/wordpress/ subdirectory for CMS-specific tools
- Moved wordpress-cron-manager.sh to new subdirectory
- Created wordpress-menu.sh submenu for WordPress tools
- Updated launcher.sh Website Management menu:
- Simplified to show general tools and CMS submenu options
- WordPress Management is now a submenu (option 3)
- Prepared structure for Joomla/Drupal/other CMS support
- Fixed script paths in wordpress-cron-manager.sh for new location
- Tested complete navigation: Main → Website → WordPress → Cron Manager
Menu Structure Now:
Website Management
├── Website Error Analyzer
├── 500 Error Tracker
└── WordPress Management (submenu)
└── WordPress Cron Manager
└── (All cron management options working)
https://claude.com/claude-code
cschantz