CRITICAL BUG - Variable Scope
Script uses 'set -e' which causes exit on ANY error. The 'local' keyword
only works inside functions, not at script level. This would cause the
batch analyzer to fail immediately.
Fix:
- Removed 'local' from all_domains_string declaration (line 97)
- Variable now correctly declared at script level
- Script can now run without exiting on scope error
Testing:
✓ Bash syntax validation passes
✓ All domain collection logic works
✓ Traffic percentage calculation correct
✓ Fair share allocation correct
✓ Edge cases handled (single domain, many domains, no logs)
CRITICAL BUG - Traffic Percentage Calculation
The batch analyzer was comparing each domain against only that user's domains,
not against all domains on the server. This caused completely inverted traffic
percentages:
- Single-domain users showed 100% traffic (wrong!)
- Traffic percentages were meaningless
- Fair share allocation was incorrect
Root Cause:
Line 160 passed $user_domains (one user's domains) instead of ALL domains
Fix:
1. Added pre-processing loop (lines 97-105) to collect ALL domains first
2. Store all domains in $all_domains_string (newline-delimited)
3. Pass $all_domains_string to get_domain_traffic_percentage() instead of $user_domains
Impact on user's 8GB server:
BEFORE:
abortionpillnyc.com: 421 requests shown as 2% of server (WRONG!)
parkmed.com: 2 requests shown as 100% of server (WRONG!)
AFTER:
abortionpillnyc.com: 421 requests = 99% of server (CORRECT!)
parkmed.com: 2 requests = 1% of server (CORRECT!)
Fair share allocation now correctly gives more capacity to high-traffic domains.
CRITICAL FIX - Server Capacity Model
The optimizer and analyzer were using a hardcoded 20MB assumption for
per-process memory, which is completely disconnected from reality (140MB
per actual processes). This caused dangerously high recommendations.
Changes:
1. lib/php-calculator-improved.sh:
- Added get_actual_memory_per_process() function that measures real
memory usage from active FPM pools via ps aux
- Updated calculate_server_capacity() to use actual measured memory
instead of hardcoded 20MB assumption
- Falls back to 140MB default if no active processes detected
2. modules/performance/php-fpm-batch-analyzer.sh:
- Changed memory impact calculation from hardcoded 20MB to using
actual memory_per_process from server capacity calculation
- Now shows realistic memory impact for each domain
3. modules/performance/php-optimizer.sh:
- Extract memory_per_process from server capacity result
- Use actual value in validation check instead of hardcoded 20MB
- Properly cap recommendations to prevent OOM
Impact on 8GB server example:
- OLD: Server capacity 241 max_children (false 20MB assumption)
- NEW: Server capacity ~42 max_children (real 140MB per process)
- Result: Recommendations go from dangerous (105+31) to safe (~5+37)
This fix ensures the entire three-constraint model (memory + traffic +
fair share) uses realistic data, not assumptions.
MAJOR ENHANCEMENT: Three-Constraint Intelligent Model
The PHP-FPM optimization now uses a sophisticated three-constraint model
to make the MOST INTELLIGENT recommendations possible:
CONSTRAINT 1: Memory-Based (What available RAM allows)
- Accounts for system reserve and MySQL memory
- Limits PHP-FPM to max 60% of total RAM
- Uses conservative 20MB per process assumption
- Results in realistic max_children values
CONSTRAINT 2: Traffic-Based (What actual usage patterns suggest)
- Analyzes peak concurrent requests from access logs
- Considers traffic stability (unstable/moderate/stable)
- Applies appropriate headroom factors (30% for stability)
- Caps at realistic traffic-based limits
CONSTRAINT 3: Fair Share (Proportional allocation based on traffic)
- Calculates server's total PHP-FPM capacity
- Allocates to each domain based on its traffic percentage
- High-traffic sites get more capacity, low-traffic get less
- Prevents single domain from monopolizing resources
FINAL RECOMMENDATION = MIN(Memory, Traffic, Fair Share)
This ensures:
- ✅ Never exceeds available RAM
- ✅ Never exceeds realistic traffic needs
- ✅ Fair distribution across domains
- ✅ Maximum capacity utilization
- ✅ Safe for shared hosting environments
NEW FUNCTIONS:
- calculate_server_capacity() - Total server PHP-FPM capacity
- get_domain_traffic_percentage() - Domain's traffic % analysis
- calculate_max_children_fair_share() - Fair share allocation
- calculate_optimal_php_settings_intelligent() - Three-constraint model
BATCH ANALYZER CHANGES:
- Step 1: Calculates server capacity once upfront
- Step 2: Analyzes domain traffic patterns
- Step 3: Uses intelligent three-constraint model for each domain
- Output now shows: traffic percentage, limiting factor per domain
EXAMPLE ON 8GB SERVER:
- Server capacity: 320 max_children total
- Site A (70% traffic, 2GB peak): Gets 224 (capped at ~105 by memory)
- Site B (30% traffic, 500MB peak): Gets 96 (limited by traffic needs)
- Combined total: ~131 max_children ≈ 2.6GB (safe within 4.8GB available)
This is production-ready for shared hosting where fair resource
distribution and safety are critical.
CRITICAL FIXES:
- Line 164: Remove 'local' from memory_reduction variable (global scope)
- Line 173: Remove 'local' from has_traffic variable (global scope)
Issue: 'local' keyword can only be used inside function definitions.
Using 'local' in global scope causes 'local: can only be used in a function'
runtime error and script failure.
RESULTS:
- 2 CRITICAL issues fixed
- Script now runs without global scope errors
ISSUE:
Batch analyzer only flagged domains for optimization when recommended < current
(only reductions). Domains needing INCREASES were marked "OK" even with:
• Critical traffic (73 concurrent requests)
• Severely undersized configuration (5 max_children)
EXAMPLE:
Current: 5, Recommended: 20, Traffic: 73 concurrent
Old: Status "OK" (no change detected)
New: Status "NEEDS OPTIMIZATION" (recognized undersizing)
FIX:
- Flag optimization when recommended != current
- ONLY if change is meaningful:
• Has significant traffic (>= 5 concurrent requests) OR
• Offers significant memory savings (>= 20% reduction)
RATIONALE:
- Domains with critical traffic should be optimized even if it increases max_children
- Undersized configurations are just as problematic as oversized ones
- Users need to see both increases and decreases in optimization recommendations
This ensures the batch analyzer surfaces all actionable optimization opportunities.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Fixed 'local' keyword errors outside function scope
- Added tracking for pm.mode, pm.max_requests, pm.min_spare_servers, pm.max_spare_servers, pm.process_idle_timeout
- Display all pool settings per domain in batch analysis
- Added combined memory capacity check (if ALL pools hit max_children)
- Status indicators for memory safety: CRITICAL/WARNING/CAUTION/HEALTHY
- Complete server-wide big picture analysis in one command
- Sort domains by priority: high-traffic optimization > low-traffic optimization > optimized
- Display traffic indicators: CRITICAL (20+), HIGH (10+), MEDIUM (5+), LOW (<5)
- Helps users focus on domains that matter most (high-traffic + need optimization)
- Uses color coding to make traffic levels visually obvious
- Includes peak concurrent request count in traffic indicator
- Makes it easy to identify which domains to optimize first
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Prompts user to save detailed report after analysis
- Generates formatted text report with full domain breakdown
- Includes server info, domain analysis, summary, and recommendations
- Shows memory impact, traffic data, and optimization potential
- Saves to /tmp with timestamp for easy reference
- Provides actionable recommendations based on findings
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Fix line 63 in php-analyzer.sh: Add default value for count variable (integer comparison error)
- Fix line 655 in php-analyzer.sh: Add default value for memory_error_count (integer comparison error)
- Fix line 396 in php-scanner.sh: Replace unsafe eval with safe getent passwd lookup
- Add php-ui.sh: User interface and menu system (18KB, 25+ functions)
- Add php-scanner.sh: Server enumeration system (17KB, 18 functions)
- Add php-action-executor.sh: Optimization execution system (17KB, 20 functions)
- Add php-server-manager.sh: Orchestration framework (21KB, 7 functions)
- Add php-fpm-batch-analyzer.sh: One-shot diagnostic script showing current vs recommended max_children, memory impact, and optimization potential
- Add comprehensive test suite (24 tests)
These fixes resolve "integer expression expected" errors during domain analysis.
Batch analyzer enables users to see domain-by-domain optimization opportunities before applying changes.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Developer