Commit Graph

4 Commits

Author SHA1 Message Date
cschantz cd38a457a4 Fix critical bugs found by QA tool: grep -F, integer comparisons, function exports
CRITICAL FIXES (8 → 0):
- Fix all 8 grep -F with regex anchors bugs
  - lib/reference-db.sh:420
  - lib/user-manager.sh:195, 254, 258, 317, 583, 590
  - modules/website/500-error-tracker.sh:313
  - Changed grep -F to grep for proper regex support

HIGH PRIORITY FIXES:
- Add 36 function exports for subshell availability
  - lib/system-detect.sh: 10 functions
  - lib/common-functions.sh: 26 functions

- Fix 27 integer comparisons with ${var:-0} validation
  - lib/common-functions.sh: 7 fixes
  - lib/ip-reputation.sh: 3 fixes
  - lib/user-manager.sh: 4 fixes
  - launcher.sh: 7 fixes
  - modules/website/500-error-tracker.sh: 1 fix
  - modules/performance/hardware-health-check.sh: 2 fixes
  - modules/performance/mysql-query-analyzer.sh: 1 fix
  - modules/security/bot-analyzer.sh: 11 fixes

- Change exit to return in library file
  - lib/common-functions.sh:246 (require_root function)

DOCUMENTATION:
- Add [DEVELOPMENT_WORKFLOW] section to REFDB_FORMAT.txt
  - Document QA script as "third option" for validation
  - Add recommended workflow for using QA tool
  - Document all 16 checks (11 bug + 5 performance)

IMPACT:
- Before: 41 issues (8 CRITICAL + 13 HIGH + 9 MEDIUM + 11 LOW)
- After: 30 issues (0 CRITICAL + 10 HIGH + 9 MEDIUM + 11 LOW)
- 27% reduction, all CRITICAL bugs eliminated

QA Tool: bash /tmp/toolkit-qa-check.sh /root/server-toolkit
2025-12-03 19:41:59 -05:00
cschantz c8d001b713 Add color code bug prevention: cecho helper + coding guidelines
PREVENTION STRATEGY for "echo without -e" bug:

1. NEW HELPER FUNCTION - cecho()
   - Added to lib/common-functions.sh (lines 100-115)
   - Wrapper around echo -e for colored output
   - Clear documentation with examples
   - Usage: cecho "${BOLD}Text${NC}" instead of echo -e

2. COMPREHENSIVE CODING GUIDELINES
   - Created CODING_GUIDELINES.md
   - Documents the echo -e color bug with examples
   - Prevention rules and quick reference table
   - Search command to find potential issues
   - Pre-commit checklist for developers
   - Performance guidelines (subprocess elimination)

3. DOCUMENTATION INCLUDES:
   - Why the bug happens (escape sequences not interpreted)
   - How to identify it (grep pattern)
   - How to fix it (echo -e or cecho)
   - When to use each approach
   - Historical context (commit 7053b3b)

BENEFITS:
- Future developers can reference guidelines
- cecho() provides cleaner, safer API
- Search pattern helps audit existing code
- Reduces recurring "This happens a lot" issues

USER FEEDBACK ADDRESSED:
User: "This happens a lot with you. is there a way for us to avoid this in the future?"
Answer: Yes - cecho() helper + guidelines document + search pattern
2025-12-02 17:14:19 -05:00
cschantz 2709352d3d Fix division by zero in progress indicator
- Add check for total=0 before calculating percentage
- Prevents crash when indexing empty user/database lists
- Displays 100% completion for empty lists
2025-11-19 16:44:24 -05:00
cschantz a51d968185 Initial commit: Server Management Toolkit v2.0
- Complete security menu restructure (3-mode: Analysis/Actions/Live)
- Intelligent cPHulk enablement with CSF whitelist import
- Live network security monitoring dashboard
- Multi-source threat detection and classification
- 50+ organized security tools across 4-level menu hierarchy
- System health diagnostics with cPanel/WHM integration
- Reference database for cross-module intelligence sharing
2025-11-03 18:21:40 -05:00