3 Commits

Author	SHA1	Message	Date
cschantz	3b23310d7d	Fix 9 MEDIUM hardcoded /var/cpanel paths - ALL MEDIUM ISSUES RESOLVED! ... FIXES: Changed hardcoded /var/cpanel paths to use environment variables with fallbacks: reference-db.sh: - Line 255: /var/cpanel/userdata → ${SYS_CPANEL_USERDATA_DIR:-/var/cpanel/userdata} - Line 265: /var/cpanel/userdata → ${SYS_CPANEL_USERDATA_DIR:-/var/cpanel/userdata} php-detector.sh: - Line 69: /var/cpanel/userdata → ${SYS_CPANEL_USERDATA_DIR:-/var/cpanel/userdata} user-manager.sh: - Line 44-45: /var/cpanel/users → ${SYS_CPANEL_USERS_DIR:-/var/cpanel/users} - Line 111: /var/cpanel/users → ${SYS_CPANEL_USERS_DIR:-/var/cpanel/users} diagnostic-report.sh: - Line 68: /var/cpanel/users → ${SYS_CPANEL_USERS_DIR:-/var/cpanel/users} wordpress-cron-manager.sh: - Line 229-230: /var/cpanel/userdata → ${SYS_CPANEL_USERDATA_DIR:-/var/cpanel/userdata} IMPACT: - Paths now configurable via environment variables - Maintains backward compatibility with default paths - Better multi-panel support flexibility - More testable code (can override paths in tests) QA STATUS: 🎉 ALL MEDIUM ISSUES RESOLVED! 🎉 - CRITICAL: 0 ✓ - HIGH: 0 ✓ - MEDIUM: 0 ✓ - LOW: 11 (remaining)	2025-12-03 20:19:43 -05:00
cschantz	645c9fd029	CRITICAL: Fix PHP-FPM pool detection - search by domain name not username ... Problem: - find_fpm_pool_config() only searched for $username.conf - cPanel EA-PHP names pool configs as $domain.conf - Example: pickledperil.com.conf NOT pickledperil.conf - Result: 'No PHP-FPM pools found' error Fix: - Modified find_fpm_pool_config() to try domain-based naming first - Falls back to username-based naming for compatibility - Search order: domain → username - Applies to all control panels (cPanel, Plesk, InterWorx) Impact: - PHP-FPM pools now detected correctly - Memory capacity analysis now works - All pool-based features functional Test: - find_fpm_pool_config('pickledperil', 'pickledperil.com') - Returns: /opt/cpanel/ea-php81/root/etc/php-fpm.d/pickledperil.com.conf	2025-12-03 01:15:04 -05:00
cschantz	0ab7b5cc3f	Fix SCRIPT_DIR variable collision in PHP libraries ... CRITICAL BUG FIX: Problem: php-detector.sh and php-analyzer.sh were setting SCRIPT_DIR which collided with parent script's SCRIPT_DIR variable causing /lib/lib/ double path bug when sourcing libraries. Solution: - Changed SCRIPT_DIR to _LIB_DIR in both php-detector.sh and php-analyzer.sh - Changed exit 1 to return 1 in sourced libraries (exit kills parent script) Files modified: - lib/php-detector.sh: Use _LIB_DIR instead of SCRIPT_DIR - lib/php-analyzer.sh: Use _LIB_DIR instead of SCRIPT_DIR, return instead of exit This prevents variable collision when libraries are sourced by modules.	2025-12-03 00:52:44 -05:00