Commit Graph

4 Commits

Author SHA1 Message Date
cschantz 8a7077aef4 Fix menu standards: Add RED 0 back buttons to remaining 6 menus
Fixed bot-analyzer.sh (2 menus):
1. show_post_analysis_menu: Changed '3) Go Back' to '0) Back' with RED
2. show_action_menu: Changed '0) Go Back' to '0) Back' with RED

Fixed malware-scanner.sh:
- show_scan_menu: Changed '0. Back to main menu' to '0) Back' with RED

Fixed live-attack-monitor.sh (2 menus):
1. show_blocking_menu: Changed '0) Cancel' to '0) Back' with RED
2. show_security_hardening_menu:
   - Changed 'q) Return to Monitor' to '0) Back' with RED
   - Updated case handler to use '0' instead of 'q|Q'

Fixed acronis-logs.sh:
- show_log_menu: Changed '0) Return to Menu' to '0) Back' (already had RED)

All 9/9 menus now use consistent RED 0 back buttons with 'Back' or 'Exit' text
2025-12-17 01:34:24 -05:00
cschantz 6a9f2cb473 Fix final 3 HIGH integer comparisons - ALL HIGH ISSUES RESOLVED!
FIXES:
acronis-logs.sh:
- Line 278: $choice → ${choice:-0} (2 instances)

acronis-register.sh:
- Line 174: $REG_EXIT_CODE → ${REG_EXIT_CODE:-0}

acronis-uninstall.sh:
- Line 217: $remaining → ${remaining:-0}

MILESTONE ACHIEVED:
🎉 ALL HIGH-PRIORITY INTEGER COMPARISON ISSUES FIXED! 🎉

QA STATUS:
- CRITICAL issues: 0 (was 8)  ✓ FIXED
- HIGH issues: 0 (was 20+)    ✓ FIXED
- MEDIUM issues: 9            (pending)
- LOW issues: 11              (pending)
- Total issues: 20 (was 41 originally)

STATISTICS:
- Files fixed: 25+
- Integer comparisons fixed: 60+
- Commits in this session: 6
- All critical bash errors eliminated!

Remaining work:
- 9 MEDIUM: Hardcoded /var/cpanel paths (multi-panel support)
- 11 LOW: bc command usage + undefined color variable
2025-12-03 20:16:00 -05:00
cschantz b98accbf61 Fix 10 HIGH integer comparisons in backup/maintenance/security modules
FIXES:
enable-cphulk.sh:
- Line 234: $file_ip_count → ${file_ip_count:-0}
- Line 333: $FAILED → ${FAILED:-0}

cleanup-toolkit-data.sh:
- Line 209: $cleaned_size → ${cleaned_size:-0} (3 instances)
- Line 236: $missing → ${missing:-0}

acronis-update.sh:
- Line 229: $UPGRADE_EXIT_CODE → ${UPGRADE_EXIT_CODE:-0}

acronis-install.sh:
- Line 301: $INSTALL_EXIT_CODE → ${INSTALL_EXIT_CODE:-0}

acronis-logs.sh:
- Line 64: $log_count → ${log_count:-0}
- Line 215: $old_logs → ${old_logs:-0}

IMPACT:
- Prevents errors in backup/maintenance scripts
- Safe defaults for all exit code checks
- More robust error handling

PROGRESS:
- Fixed 57+ integer comparison issues total
- Only 3 HIGH issues remaining!
- Total issues: 23 (was 41 originally)
2025-12-03 20:14:37 -05:00
cschantz e7eaabfcc5 Implement Acronis Cyber Protect agent management scripts
Created 11 comprehensive scripts for Acronis backup management:

Installation & Setup:
- acronis-install.sh: Download/install agent with multiple modes
  * Interactive, unattended, with/without registration
  * Supports token-based registration during install
  * Auto-service startup and verification
- acronis-register.sh: Register agent with Acronis Cloud
  * Validates service URL and token
  * Shows current registration status
  * Safe re-registration with confirmation
- acronis-configure.sh: Guidance for backup plan configuration
  * Web console walkthrough
  * Common backup plan examples

Backup Operations:
- acronis-manual-backup.sh: Manual backup creation guide
  * Web console and CLI methods
  * Ready for full CLI implementation
- acronis-status.sh: View backup status from logs
  * Recent backup activity
  * acrocmd integration ready
- acronis-list-backups.sh: List available backup archives
  * acrocmd integration for archive listing
- acronis-restore.sh: Restore from backup guide
  * Multiple restore methods explained
  * Safety warnings and best practices

Management:
- acronis-agent-status.sh: Comprehensive service status
  * All 4 services (aakore, mms, schedule, active-protection)
  * Registration status, network ports, storage
  * Quick actions: start/stop/restart/logs/version
- acronis-update.sh: Agent update management
  * Auto and manual update methods
  * Version checking
- acronis-logs.sh: Advanced log viewer
  * View, tail, search logs
  * Error filtering with color coding
  * Log archival for old logs
- acronis-uninstall.sh: Safe agent removal
  * Stops services, unregisters, removes packages
  * Optional data retention
  * Comprehensive cleanup

All scripts based on documented Acronis commands with proper error
handling, status validation, and user-friendly interfaces.
2025-11-05 21:30:19 -05:00