CRITICAL FIXES:
- Sendmail queue count extraction: Changed from 'first number' (Kbytes) to 'number after in' (message count)
- Both Postfix and Sendmail now use identical extraction: grep -oE 'in [0-9]+' | grep -oE '[0-9]+'
- Exim frozen detection: Only count lines starting with [frozen] marker (not all "frozen" occurrences)
- Sendmail deferred detection: POSIX-compliant regex [[:space:]]* (not \s)
VERIFICATION RESULTS:
✅ Exim: Correctly detects frozen message markers only
✅ Postfix: Correctly extracts message count from summary (not Kbytes)
✅ Sendmail: Now correctly extracts message count matching Postfix format
✅ All three MTAs: Properly detect frozen/suspended/deferred messages
✅ Edge cases: Empty queues, large queues, special characters, UTF-8, IP addresses
✅ POSIX compatibility: All regex patterns portable across distributions
IMPROVEMENTS:
- Added detailed comments explaining extraction patterns
- Consistent queue count extraction for both Postfix and Sendmail
- Better error handling and empty queue detection
- MTA-specific help commands for troubleshooting
This script is production-ready with all parsing patterns verified against real-world MTA output.
CRITICAL FIXES (5 issues):
1. email-diagnostics.sh: Fix inverted sender/recipient extraction logic
- Lines 292-303: Corrected pattern matching to properly extract recipients and senders
- Removed inverted grep patterns that were looking for wrong log entry types
2. mail-log-analyzer.sh: Fix string comparison with percent sign
- Line 1184-1186: Properly extract numeric value before '%' character
- Use sed to isolate leading digits for numeric comparison
3. email-diagnostics.sh: Fix malformed grep syntax
- Line 525-527: Corrected grep command structure with -e options
- Changed to -iE with pipe patterns and proper file argument placement
4. mail-log-analyzer.sh: Fix overly broad domain bounce pattern
- Line 749: Changed from "^.*${domain}" to "\b${domain}$"
- Prevents false positives from substring domain matches
5. mail-log-analyzer.sh: Fix undefined TEMP_LOG variable
- Line 860: Changed TEMP_LOG to MAIL_LOG (the actual global variable)
- Added error handling with 2>/dev/null
HIGH SEVERITY FIXES (2 issues):
6. mail-log-analyzer.sh: Fix AWK uninitialized variable
- Lines 1447-1456: Added BEGIN block to initialize print_line = 0
- Prevents first log entries from being incorrectly filtered
7. mail-log-analyzer.sh: Fix overly permissive bounce detection pattern
- Line 247: Changed from "(==|defer)" to more specific pattern
- Prevents false positives from non-bounce defer messages
MODERATE FIXES (3 issues):
8. mail-queue-inspector.sh: Fix queue message count mismatch
- Line 41: Changed head -40 to head -20 to match label
9. deliverability-test.sh: Fix fragile SMTP connection test
- Lines 102-106: Added nc availability check and fallback to bash TCP
- Proper variable quoting and error handling
10. blacklist-check.sh: Replace deprecated host command with dig
- Line 52: Changed from host to dig +short for consistency and timeout control
All scripts pass syntax validation.
Impact: Logic errors fixed, no security issues introduced, all existing functionality preserved.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Developer