Added validation checks for potentially empty variables before use
to prevent errors and unsafe operations.
WordPress Cron Manager (5 fixes):
- Added site_path validation after dirname operations
- Prevents using empty paths in cd commands and file operations
- Pattern: Check [ -z "$site_path" ] before use
Bot Analyzer:
- Quoted TEMP_DIR in trap command for safety
Hardware Health Check:
- Quoted MESSAGES_CACHE in trap command for safety
Note: 5 issues flagged in toolkit-qa-check.sh were false positives
(echo statements demonstrating bad patterns, not actual code issues)
Problem:
When run from the launcher menu, the hardware health check script
would exit the entire toolkit after completion instead of returning
to the menu. This was frustrating for users who wanted to run multiple
operations.
Root Cause:
The script used `exit 0/1/2` at the end to provide severity-based exit
codes for monitoring system integration. However, this caused the script
to terminate the parent shell when sourced by the launcher.
Solution:
Detect execution context and use appropriate behavior:
1. Standalone Execution (./hardware-health-check.sh):
- Use `exit` codes (0, 1, 2) for monitoring integration
- Script terminates as expected for cron/monitoring tools
2. Sourced Execution (called from launcher):
- Use `return` codes (0, 1, 2) instead of exit
- Returns control to launcher menu
- Exit codes still available via $? if launcher wants to check
Detection Method:
if [ "${BASH_SOURCE[0]}" = "${0}" ]; then
# Script run directly → use exit
else
# Script sourced by launcher → use return
fi
Changes to modules/performance/hardware-health-check.sh:
- Lines 1840-1854: Added execution context detection
- Standalone: exit 0/1/2 (monitoring integration)
- Sourced: return 0/1/2 (back to menu)
- Lines 1857-1863: Only auto-run main if executed directly
Benefits:
✅ Returns to menu when run from launcher
✅ Still provides exit codes for monitoring tools
✅ Best of both worlds - works in all contexts
✅ No breaking changes to monitoring integration
Testing:
- Standalone: ./hardware-health-check.sh → exits with code
- From launcher: Returns to menu ✅
User Report: "when the script exists it is not built into taking back
to the menu. it just runs and exits everything once its done"
Status: ✅ FIXED - Now returns to menu properly
Enhancement: Show exactly what devices were skipped and why
Problem:
The disk summary showed "Total disks checked: 2" but only displayed
1 disk in the report. Users couldn't tell what was skipped or why.
Solution:
Added comprehensive skip tracking and breakdown in summary:
Skip Counters Added:
- skipped_count: Total devices skipped
- skipped_raid: Hardware RAID controllers
- skipped_virtual: Virtual/cloud disks
- skipped_lvm: Software RAID/LVM volumes
- skipped_other: USB/special devices
Summary Now Shows:
✅ Total devices found: X
✅ Physical disks monitored: X healthy, X warning, X failed
✅ Devices skipped (SMART not applicable): X
• Hardware RAID controllers: X (use vendor tools)
• Software RAID/LVM: X (monitor underlying disks)
• Virtual/cloud disks: X (managed by hypervisor)
• Other (USB/special): X (see findings for details)
Example Output (Physical Server with RAID):
Before:
Total disks checked: 2
Healthy: 1
Warning: 0
Failed: 0
After:
Total devices found: 2
Physical disks monitored: 1 healthy, 0 warning, 0 failed
Devices skipped (SMART not applicable): 1
• Hardware RAID controllers: 1 (use vendor tools)
Benefits:
✅ Crystal clear what was skipped and why
✅ Users understand the complete device inventory
✅ Each skip type has helpful guidance
✅ No confusion about missing devices
Changes to modules/performance/hardware-health-check.sh:
- Lines 139-147: Added skip counter variables
- Lines 160-161, 168-169: Track inaccessible devices as skipped
- Lines 210-211: Track RAID controllers as skipped
- Lines 252-253: Track virtual disks as skipped
- Lines 261-262: Track LVM/software RAID as skipped
- Lines 285-286, 294-295: Track other special devices as skipped
- Lines 560-588: Enhanced summary with skip breakdown
User Request: "add anythihg minor to enhance it"
Status: ✅ COMPLETE - Summary now shows full device inventory breakdown
- Complete security menu restructure (3-mode: Analysis/Actions/Live)
- Intelligent cPHulk enablement with CSF whitelist import
- Live network security monitoring dashboard
- Multi-source threat detection and classification
- 50+ organized security tools across 4-level menu hierarchy
- System health diagnostics with cPanel/WHM integration
- Reference database for cross-module intelligence sharing
cschantz