Linux-Server-Management-Toolkit/CORRECTED_AUDIT_SUMMARY.md

CORRECTED Audit Summary - After Triple-Check

Date: 2025-12-23

Status: TRIPLE-CHECKED AND VERIFIED

---

CRITICAL CORRECTION

My initial audit report (PLATFORM_AUDIT_FINDINGS.md) was LARGELY INCORRECT.

After triple-checking the actual code, here's what's REALLY true:

---

ACTUAL FINDINGS

✅ GOOD NEWS - What Already Works:

1. lib/domain-discovery.sh - FULLY MULTI-PLATFORM ✅

   • ALL 13 functions have Plesk cases ✓
   • ALL 13 functions have standalone fallbacks ✓
   • Functions like list_all_domains(), get_domain_owner(), etc. work on all platforms

2. lib/system-detect.sh - Detects all platforms correctly ✅

3. lib/plesk-helpers.sh - 31 Plesk helper functions ready ✅

4. lib/user-manager.sh - Already has Plesk/InterWorx/standalone support ✅

5. build_domains_section() HAS fallback logic ✅

   • Lines 333-359: else branch for non-cPanel systems
   • Uses get_user_domains() which is panel-agnostic
   • Works on Plesk/standalone already!

---

❌ ACTUAL ISSUES FOUND (Only 3, not 8!):

Issue #1: build_domains_section() - cPanel Userdata Optimization

Severity: MEDIUM (not critical!) Location: Lines 255-332

The function has TWO code paths:

1. Lines 255-332: Optimized cPanel path (parses userdata files for detailed info)
2. Lines 333-359: Fallback path for ALL other systems (uses panel-agnostic functions)

Problem: The cPanel path gets richer data (PHP version, aliases, HTTP status, domain type) Impact: Plesk/standalone get less detailed domain information, but they DO work

Not a blocker - just means Plesk won't get as detailed info as cPanel

---

Issue #2: /etc/localdomains and /etc/remotedomains - Not Wrapped

Severity: LOW (cosmetic, not critical!) Location: Lines 364-396

# Check /etc/localdomains (cPanel local domains not yet added)
if [ -f "/etc/localdomains" ]; then
    # ...
fi

Problem: Not wrapped in if [ "$SYS_CONTROL_PANEL" = "cpanel" ] Impact: NONE - the if [ -f "/etc/localdomains" ] check means it skips silently on non-cPanel Fix: Nice to have for code cleanliness, but not blocking anything

---

Issue #3: WordPress Path Parsing - Hardcoded /home/

Severity: MEDIUM Location: Lines 411, 414

# Line 405: Uses $SYS_USER_HOME_BASE - THIS IS GOOD ✅
local wp_configs=$(find $SYS_USER_HOME_BASE -name "wp-config.php" -type f 2>/dev/null)

# Line 411: Assumes field 3 is username - BREAKS ON PLESK ❌
local username=$(echo "$wp_dir" | cut -d'/' -f3)

# Line 414: Hardcodes /home/ - BREAKS ON PLESK ❌
local path_after_home=$(echo "$wp_dir" | sed "s|^/home/$username/||")

Problem: Path parsing assumes /home/username/ structure Impact: WordPress detection works but extracts wrong username/domain on Plesk Fix Needed: Panel-specific path parsing logic

---

WHAT THIS MEANS

For Plesk Support:

Current State: MOSTLY WORKING! 🎉

• ✅ Domain discovery works (via fallback path)
• ✅ User detection works
• ✅ Database detection works
• ⚠️ WordPress detection works but gets wrong owner/domain
• ⚠️ Domain details less rich than cPanel (no PHP version, aliases, status codes)

To Make Plesk Excellent:

1. Create build_domains_plesk() function (get richer Plesk domain data)
2. Fix WordPress path parsing for Plesk paths
3. Optionally wrap /etc/localdomains checks (code cleanliness)

For Standalone Support:

Current State: BASIC SUPPORT EXISTS! 🎉

• ✅ domain-discovery.sh has standalone fallbacks for ALL functions
• ✅ Scans /var/www/, /home/, common web directories
• ✅ Uses stat -c "%U" for ownership
• ⚠️ WordPress detection works but path parsing needs improvement

To Make Standalone Excellent:

1. Add vhost parsing (Apache/Nginx configs) - currently just scans directories
2. Fix WordPress path parsing for various web roots
3. Create build_domains_standalone() for richer data

---

REVISED IMPLEMENTATION PLAN

Priority 1: Quick Plesk Fixes (2-3 hours)

Goal: Make Plesk experience match cPanel quality

1. Create build_domains_plesk() function (1 hour)

   • Use plesk bin site --list
   • Call plesk_get_docroot(), plesk_get_logdir(), etc.
   • Get PHP version, SSL status from Plesk
   • Format same as cPanel output

2. Fix WordPress path parsing (1 hour)

   • Add panel-specific logic for username/domain extraction
   • Test on both cPanel and Plesk paths

3. Wrap cPanel-only file checks (15 minutes)

   • Add if [ "$SYS_CONTROL_PANEL" = "cpanel" ] around lines 364-396
   • Code cleanliness

Priority 2: Enhanced Standalone Support (4-6 hours)

Goal: Parse vhost configs instead of just directory scanning

1. Create lib/standalone-helpers.sh (3 hours)

   • standalone_parse_apache_vhosts() - read ServerName from configs
   • standalone_parse_nginx_vhosts() - read server_name from configs
   • Extract DocumentRoot, log paths, aliases from configs

2. Create build_domains_standalone() (2 hours)

   • Use vhost parser for domain discovery
   • Get richer domain data (document roots, log paths)
   • Format similar to cPanel output

3. Test on Ubuntu/Debian/AlmaLinux (1 hour)

---

CORRECTED TIMELINE

Week 1:

• Day 1 (4 hours): Priority 1 - Plesk fixes
• Day 2 (2 hours): Test Plesk fixes on Plesk server
• Days 3-4 (8 hours): Priority 2 - Standalone vhost parsing
• Day 5 (2 hours): Test standalone on Ubuntu/AlmaLinux

Week 2:

• Days 1-2: Integration testing all platforms
• Days 3-5: Bug fixes, edge cases, documentation

---

BOTTOM LINE

My initial audit was OVERLY PESSIMISTIC.

The codebase is in MUCH BETTER shape than I thought:

Component	Initial Assessment	CORRECTED Assessment
domain-discovery.sh	❌ No standalone support	✅ Full multi-platform
reference-db.sh	❌ 100% cPanel-only	⚠️ Works on all, needs optimization
WordPress detection	❌ Completely broken	⚠️ Works, needs path fix
Overall	"2-3 weeks"	"3-5 days"

---

WHAT TO DO NEXT

RECOMMENDED: Start with Priority 1 (Plesk fixes)

1. Create build_domains_plesk() function
2. Fix WordPress path parsing
3. Test on Plesk server
4. IF working well, proceed to Priority 2 (standalone vhost parsing)

ALTERNATIVE: Test current code on Plesk server FIRST

• The fallback path might already work well enough
• WordPress issue might not be critical if domain detection works
• Could skip all enhancements and just use existing code

---

Apologies for the initial incorrect audit. The good news is the code is in much better shape than I thought!

---

Files to Review:

• ❌ DELETE: PLATFORM_AUDIT_FINDINGS.md (incorrect)
• ✅ READ: This file (CORRECTED_AUDIT_SUMMARY.md)
• ✅ KEEP: CROSS_PLATFORM_PLAN.md (still valid, just less work needed)