Files
Linux-Server-Management-Too…/modules/security
cschantz 4a9f40ce53 CRITICAL FIX: Resolve subshell data loss preventing auto-blocking
Problem:
- Scores showing 100 in display but IPs NOT being auto-blocked
- HTTP/SSH/network monitoring run in subshells (pipe/background processes)
- IP_DATA array updates in subshells invisible to parent process
- Auto-mitigation engine reading stale ip_data file with score=0
- Result: SUSPICIOUS_UA and other attacks never triggering blocks

Root Cause:
```bash
tail -F logs | while read line; do
    IP_DATA[$ip]=100  # Updates in SUBSHELL - parent never sees it!
done
```

Solution:
1. Added write_ip_data_to_file() with flock-based locking
2. Every IP_DATA update now writes directly to ip_data file
3. Auto-mitigation engine can now see real-time scores
4. Fixed in 8 locations:
   - update_ip_intelligence (main scoring)
   - HTTP log monitoring (ET attacks)
   - AbuseIPDB reputation boost (3 levels)
   - cPHulk monitoring
   - SYN flood detection
   - Port scan detection

Testing:
- SUSPICIOUS_UA reaching score 100 will now auto-block
- All attack types properly trigger mitigation
- File locking prevents race conditions
- Background writes prevent blocking main loop

This fixes the #1 reported issue where attacks showed critical
scores but were never blocked.
2026-01-06 17:27:04 -05:00
..