Previous attempt (commit 9b0a145) moved ALL variable exports inside the
conditional, which broke the script because variables weren't initialized
on subsequent runs after SYS_DETECTION_COMPLETE was set.
The CORRECT Fix:
Move SYS_USER_HOME_BASE and other session variables INSIDE the conditional
so they're only initialized ONCE, not reset every time system-detect.sh
is sourced.
Changes:
1. lib/system-detect.sh (lines 26-32):
- Moved SYS_USER_HOME_BASE="" inside conditional
- Moved SYS_PHP_VERSIONS=() inside conditional
- Moved firewall variables inside conditional
- Now all exports only run when SYS_DETECTION_COMPLETE is empty
2. launcher.sh (line 22):
- Re-added: source "$LIB_DIR/domain-discovery.sh"
- Lost when reverting broken commit
Impact:
- Fixes Plesk: SYS_USER_HOME_BASE="/var/www/vhosts" persists
- Fixes cPanel: launcher completes successfully and shows menu
- list_all_domains() and all unified functions now available
Tested on cPanel: ✅ WORKING
Ready for Plesk testing
cschantz
65c523f005