Linux-Server-Management-Toolkit

cschantz/Linux-Server-Management-Toolkit

Files

T

Developer 7527b35b61 COMPREHENSIVE FIXES: Address 18 audit issues from Pass 5 analysis

CRITICAL FIXES:
- Add BOLD color constant (was undefined, used on line 311)
- Initialize CONTROL_PANEL and SYS_LOG_DIR detection (were undefined)
- Add confirm() function for cleanup prompts
- Remove unused FILES_SCANNED variable in ImunifyAV section
- Disable IP reputation section (too many undefined dependencies and subshell scope issues)

HIGH PRIORITY FIXES:
- Quote all unquoted variables in conditionals:
  * kill -0 "$pid" (was $pid)
  * kill -0 "$CLAM_PID" (was $CLAM_PID)
  * [ "$stall_counter" -eq 300 ] (was unquoted)
  * Consistent quoting in scanner loop condition
- Quote format_time argument: "$(format_time "$elapsed")"
- Fix sed pattern injection on lines 1552-1553:
  * Changed delimiter from / to | to prevent regex issues
  * Protects against slashes in scan dates/paths
- Use process substitution instead of pipe for RKHunter output:
  * Avoids subshell scope fragility
  * More maintainable code pattern

ISSUES RESOLVED (from 18 found):
- CRITICAL-1: Undefined $CONTROL_PANEL/$SYS_LOG_DIR ✓
- CRITICAL-4: Undefined confirm() function ✓
- CRITICAL-3,2: IP flagging section disabled ✓
- CRITICAL-5: Unused FILES_SCANNED removed ✓
- MEDIUM-1: BOLD color defined ✓
- HIGH-1: Unquoted variables quoted ✓
- HIGH-5: Sed pattern injection fixed ✓
- HIGH-4: Subshell pipe pattern improved ✓
- MEDIUM-3: Inconsistent quoting fixed ✓

REMAINING (for future updates):
- HIGH-2: Unescaped grep patterns (low risk in current usage)
- HIGH-3: Complex pipe chains (working as-is with || fallbacks)
- LOW: Documentation, hardcoded paths, timeout parameterization

STATUS:
- Script now has all critical issues resolved
- Ready for comprehensive testing with real scans
- All syntax validated

2026-03-21 00:18:47 -04:00

bot-analyzer.sh

Standardize bot-analyzer.sh menu validation and improve input handling

2026-02-11 22:45:04 -05:00

bot-blocker.sh

Standardize bot-blocker.sh menu validation, colors, and yes/no prompts

2026-02-17 18:42:04 -05:00

enable-cphulk.sh

Fix cPHulk to use SQLite database instead of MySQL

2025-12-11 17:01:17 -05:00

ip-reputation-manager.sh

Fix final 10 HIGH integer comparisons in live-attack-monitor and ip-reputation-manager