Critical Bug Found:
The same attack was being scored TWICE:
1. update_ip_intelligence() detects attack via legacy patterns → adds 85 points
2. ET detection finds same attack → adds 95 points on top
3. Result: 85 + 95 = 180 (capped at 100)
Example:
- Request: /wp-includes/alfa-rex.php
- Legacy detection: "webshell" → +85 score
- ET detection: "alfa_shell" → +95 score
- Total: 180 → capped at 100 (WRONG!)
Root Cause:
Lines 1705 + 1731-1735 in live-attack-monitor.sh:
- Line 1705: update_ip_intelligence() runs legacy detection
- Line 1731: Read score from IP_DATA (includes legacy score)
- Line 1731: Add ET score to existing score (DOUBLE COUNT)
Fix Applied (lines 1726-1741):
Changed from ADDITION to MAX selection:
Before:
new_score = curr_score + et_attack_score # Double counting!
After:
new_score = MAX(curr_score, et_attack_score) # Use higher score
Logic:
- If ET detects attack: Use ET score (more accurate)
- If curr_score is higher: Keep it (e.g., AbuseIPDB reputation boost)
- This ensures the most relevant score is used without double-counting
Testing:
✅ Test 1: Legacy=85, ET=95 → Final=95 (was 100)
✅ Test 2: Reputation=110, ET=75 → Final=100 (preserved higher score)
✅ No more double counting
Impact:
- More accurate threat scoring
- ET scores now properly reflect attack severity
- Reputation scores from AbuseIPDB are preserved when higher
cschantz
84d06b4744