Fix critical bugs and missing production features in wordpress-cron-manager.sh:
BUG FIXES (9 issues resolved):
- A1: Fixed "every 15 minutes" doc bug → "once per hour" (Case 2 line 813)
- A2: Standardize backup method in Cases 3,4,6,7,8 → create_timestamped_backup()
- A3: Add post-modification syntax validation to Cases 3,4,6,7,8
- A6: Fix disable_wp_cron_exists() false positives on commented lines
- A7: Fix Case 3 to use per-site user extraction (not $target_user for all)
- A8: Remove dead `continue` in Case 2 (was no-op outside loop)
- A9: Add failure counters to bulk cases (3, 4, 7, 8)
- A4, A5: Identified hardcoded cPanel paths in Cases 5,6 (deferred multi-panel refactor)
PRODUCTION FEATURES (3 new):
- B1: Lock file mechanism via flock to prevent concurrent execution
Ephemeral lock in /tmp (auto-cleanup on EXIT/INT/TERM)
No permanent trace left on system
- B2: Dry-run mode support via --dry-run flag
Preview all changes without making modifications
Shows [DRY-RUN] messages for each operation
Applied to all write operations in Cases 2,3,4,6,7,8
- B3: PHP binary validation before adding cron jobs
Detects PHP location via command -v with /usr/bin/php fallback
Validates binary exists and is executable
Prevents cron jobs with broken PHP path
IMPROVEMENTS BY CASE:
Case 2: Uses PHP_BIN instead of hardcoded /usr/bin/php
Case 3: +failed counter, per-site user extraction, backup+validation, dry-run
Case 4: +failed counter, backup+validation, PHP binary check, dry-run
Case 6: Backup+validation, dry-run (still has hardcoded cPanel paths)
Case 7: +failed counter, backup+validation, dry-run
Case 8: +failed counter, backup+validation, PHP binary check, dry-run
VERIFICATION:
✓ Bash syntax check passed
✓ Lock file prevents concurrent execution
✓ Dry-run mode functional across all cases
✓ No permanent system artifacts created
✓ All backups validated post-modification
✓ Failures tracked separately from successes
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cschantz
01801cfe24