cschantz
d3cf199620
Improve QA script accuracy - fix false positives
QA SCRIPT IMPROVEMENTS:
1. CHECK 12 (Dangerous rm) - Skip echo/comment lines
- Added filter to skip lines starting with 'echo' or '#'
- Prevents false positives on documentation/examples
- Example: "echo 'run: rm -rf \$DIR'" is now correctly ignored
2. CHECK 18 (Parameter validation) - Accept variable name patterns
- Old pattern: Only detected [ -z "$1" ] or [ -n "$1" ]
- New pattern: Also accepts [ -z "$var_name" ] after assignment
- Regex: \[\s*-[nz]\s*"\$([1-9]|[a-zA-Z_][a-zA-Z0-9_]*)"\s*\]
- This recognizes both direct ($1) and indirect ($db_name) validation
BENEFITS:
- Reduces false positives in rm command detection
- More flexible parameter validation detection
- Better matches real-world bash coding patterns
- Accepts both defensive coding styles
TESTING:
✓ No change in issue count (99 issues - still accurate)
✓ CRITICAL: 0 (validated - no false positives)
✓ HIGH: 10 (same functions, better detection logic)