cschantz/Linux-Server-Management-Toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

OPTIMIZATION: Eliminate duplicate get_user_domains() calls

Browse Source 
ISSUE:
Lines 173-174 called get_user_domains() twice for the same user:
  local primary_domain=$(get_user_domains "$user" | head -1)
  local domain_count=$(get_user_domains "$user" | grep -v "^$" | wc -l)

This caused redundant function execution and system scanning.

FIX:
Call function once, store output, reuse:
  local user_all_domains=$(get_user_domains "$user")
  local primary_domain=$(echo "$user_all_domains" | head -1)
  local domain_count=$(echo "$user_all_domains" | grep -v "^$" | wc -l)

IMPACT:
- Eliminates redundant system scans (Apache configs, directory traversal)
- Faster database building
- Less system load during detection

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
Developer
2026-03-19 22:06:48 -04:00
parent ce8babe62f
commit 8e0fc369e5
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/reference-db.sh
+4 -2
View File
@@ -170,8 +170,10 @@ build_users_section() {
current=$((current + 1))
show_progress $current $total_users "Indexing users..."
local primary_domain=$(get_user_domains "$user" | head -1)
local domain_count=$(get_user_domains "$user" | grep -v "^$" | wc -l)
# Get all domains once and reuse (avoid duplicate function calls)
local user_all_domains=$(get_user_domains "$user")
local primary_domain=$(echo "$user_all_domains" | head -1)
local domain_count=$(echo "$user_all_domains" | grep -v "^$" | wc -l)
local db_count=$(get_user_databases "$user" | grep -v "^$" | wc -l)
# Get disk usage (quick du)