Fix: Comprehensive quality issues in malware-scanner.sh
ISSUES FIXED:
1. **Array expansion in echo (lines 1664, 1871):**
- Changed ${SCAN_PATHS[@]} to ${SCAN_PATHS[*]} for proper expansion in echo context
- Prevents word splitting issues with paths containing spaces
2. **UUOC (Useless Use of Pipe) with echo (lines 1716-1720):**
- Removed: $(echo "$malicious_output" | head -1)
- Replaced with: "${malicious_output%%$'\n'*}" (bash parameter expansion)
- Replaced pipe-based wc with printf to avoid unnecessary processes
3. **C-style increment operators (lines 2141, 2148, 2154, 2162, 2169, 2213):**
- Changed ((var++)) to var=$((var + 1)) for consistency with project style
- Follows CLAUDE.md guidance: use proper arithmetic syntax
- Applied to: validation_issues and real_threats_count variables
4. **Sed escaping incomplete (line 2325):**
- Added explicit backslash escaping before other character escaping
- Changed: 's/[\/&|]/\\&/g'
- To: 's/\\\\\\\\\\\\/g; s/[\/&|]/\\&/g'
- Ensures paths with backslashes are properly escaped for sed replacement
5. **Unquoted PID variable (lines 2380, 2392):**
- Added quotes around $scan_pid in: ps -p "$scan_pid"
- Added quotes in printed command: echo " ps -p \"$scan_pid\""
- Defensive programming best practice
VERIFICATION:
- Syntax check: bash -n passes
- No functional changes to logic
- All fixes follow CLAUDE.md guidelines
IMPACT:
- More robust path handling (spaces, special characters)
- Better resource efficiency (fewer subshells)
- Consistent with codebase standards
- Improved reliability with edge cases
Developer
2bf8c4f275