Developer 2bf8c4f275 Fix: Comprehensive quality issues in malware-scanner.sh
ISSUES FIXED:

1. **Array expansion in echo (lines 1664, 1871):**
   - Changed ${SCAN_PATHS[@]} to ${SCAN_PATHS[*]} for proper expansion in echo context
   - Prevents word splitting issues with paths containing spaces

2. **UUOC (Useless Use of Pipe) with echo (lines 1716-1720):**
   - Removed: $(echo "$malicious_output" | head -1)
   - Replaced with: "${malicious_output%%$'\n'*}" (bash parameter expansion)
   - Replaced pipe-based wc with printf to avoid unnecessary processes

3. **C-style increment operators (lines 2141, 2148, 2154, 2162, 2169, 2213):**
   - Changed ((var++)) to var=$((var + 1)) for consistency with project style
   - Follows CLAUDE.md guidance: use proper arithmetic syntax
   - Applied to: validation_issues and real_threats_count variables

4. **Sed escaping incomplete (line 2325):**
   - Added explicit backslash escaping before other character escaping
   - Changed: 's/[\/&|]/\\&/g'
   - To: 's/\\\\\\\\\\\\/g; s/[\/&|]/\\&/g'
   - Ensures paths with backslashes are properly escaped for sed replacement

5. **Unquoted PID variable (lines 2380, 2392):**
   - Added quotes around $scan_pid in: ps -p "$scan_pid"
   - Added quotes in printed command: echo "  ps -p \"$scan_pid\""
   - Defensive programming best practice

VERIFICATION:
- Syntax check: bash -n passes
- No functional changes to logic
- All fixes follow CLAUDE.md guidelines

IMPACT:
- More robust path handling (spaces, special characters)
- Better resource efficiency (fewer subshells)
- Consistent with codebase standards
- Improved reliability with edge cases
2026-04-21 21:17:01 -04:00
2025-11-03 18:14:51 -05:00

🧪 Linux Server Toolkit - DEV Branch

STATUS: 🚀 Development & Testing Branch (Separate from Production)

This is the dev branch for testing, development, and experimentation. Changes here are isolated from production and can be safely tested before merging to main.


🚀 Quick Start

One command - pulls dev branch with YELLOW ⚠️ BETA banner:

curl -sL https://git.mull.lol/cschantz/Linux-Server-Management-Toolkit/archive/dev.tar.gz | tar xz && source linux-server-management-toolkit/run.sh

When exiting (option 0), answer "yes" and cleanup happens automatically - no extra steps.


📍 Key Differences (Dev vs Production)

Feature Dev Branch Production
Cache .sysref.beta .sysref
Version 2.1.0-BETA 2.1.0
Banner 🟨 Yellow (⚠️) 🔵 Cyan
Git Branch dev main
Purpose Testing & Development Stable/Production

📦 Features

Comprehensive multi-panel server management suite supporting cPanel, InterWorx, Plesk, and standalone Apache with:

  • 🛡️ Security & Monitoring: Live attack monitor, bot blocker, malware scanner, IP reputation
  • 💾 Backup & Recovery: Acronis management, MySQL database restore
  • 🌐 Website Diagnostics: Error analysis, WordPress tools, Cloudflare detection
  • 📧 Email Diagnostics: Mail queue, blacklist checker, SPF/DKIM/DMARC validation
  • 📊 Performance Analysis: MySQL optimization, PHP tuning, hardware health, Varnish cache
  • 🔍 System Diagnostics: Health checks, loadwatch analysis, bandwidth monitoring

📖 Documentation

For detailed documentation, see the main repository: https://git.mull.lol/cschantz/Linux-Server-Management-Toolkit


Version: 2.1.0-BETA Repository: https://git.mull.lol/cschantz/Linux-Server-Management-Toolkit Branch: dev

S
Description
No description provided
Readme MIT 18 MiB
Languages
Shell 100%